Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped Patients page in mobie view #3258

Merged
merged 14 commits into from
Aug 25, 2022
Merged

Revamped Patients page in mobie view #3258

merged 14 commits into from
Aug 25, 2022

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Jul 29, 2022 •
edited
Loading

@Pranshu1902 Pranshu1902 requested a review from a team July 29, 2022 09:17
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner July 29, 2022 09:17
@netlify
Copy link

netlify bot commented Jul 29, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a4dbb3a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6307120dc5b75100081d9b7d
😎 Deploy Preview https://deploy-preview-3258--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ashesh3
Ashesh3 requested changes Jul 31, 2022
View reviewed changes
src/Components/Patient/PatientHome.tsx Outdated Show resolved Hide resolved
@nihal467
Copy link
Member

nihal467 commented Aug 9, 2022

@Pranshu1902 make it responsive
image

@Pranshu1902
Copy link
Contributor Author

@nihal467
updated view:
image

@nihal467
Copy link
Member

nihal467 commented Aug 16, 2022 •
edited
Loading

@Pranshu1902
image
image

test failed, make the page responsive

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

image

@nihal467
Copy link
Member

@Pranshu1902
image

reflection can't see it

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Aug 17, 2022 •
edited
Loading

@nihal467
I did get it, text-overflow has been handled (probably, cache hasn't been cleared)
image

@nihal467
Copy link
Member

@Pranshu1902 test failed
image

@Pranshu1902
Copy link
Contributor Author

@nihal467
error resolved

@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar requested changes Aug 23, 2022
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 check this one out

@khavinshankar khavinshankar added question Further information is requested and removed tested labels Aug 23, 2022
@Pranshu1902 Pranshu1902 added tested and removed question Further information is requested labels Aug 23, 2022
@khavinshankar khavinshankar added merge conflict pull requests with merge conflict and removed tested labels Aug 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@khavinshankar khavinshankar merged commit cb56abb into coronasafe:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 requested changes

@khavinshankar khavinshankar khavinshankar approved these changes

@tomahawk-pilot tomahawk-pilot Awaiting requested review from tomahawk-pilot

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp Patient Details page in mobile view
4 participants
@Pranshu1902 @nihal467 @Ashesh3 @khavinshankar