Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Asset Page Malfunction #3266

Merged
merged 5 commits into from
Aug 25, 2022
Merged

Fixed: Asset Page Malfunction #3266

merged 5 commits into from
Aug 25, 2022

Conversation

aeswibon
Copy link
Member

Updates

  • Fixes Asset Page Malfunction #3265
  • Added position prop to SelectMenu
  • Made SelectMenu's options to appear based on position prop
  • Removed unused imports
  • Replaced classNames with clsx

@aeswibon aeswibon requested a review from a team July 30, 2022 05:41
@aeswibon aeswibon requested a review from a team as a code owner July 30, 2022 05:41
@aeswibon aeswibon requested a review from gigincg July 30, 2022 05:41
@netlify
Copy link

netlify bot commented Jul 30, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 716d48d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62ffc3ca3bd5bb0008c4c898
😎 Deploy Preview https://deploy-preview-3266--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@cp-Coder make it responsive
image

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2022

image

@cp-Coder make it responsive

This was referenced Aug 19, 2022
Closed
Closed
@sonarcloud
Copy link

sonarcloud bot commented Aug 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aeswibon aeswibon mentioned this pull request Aug 20, 2022
Closed
@nihal467
Copy link
Member

Test approved

@khavinshankar khavinshankar merged commit 71aca29 into coronasafe:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
good to merge tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Asset Page Malfunction
4 participants
@aeswibon @nihal467 @Ashesh3 @khavinshankar