Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added prn prescription #3288

Merged
merged 6 commits into from
Aug 27, 2022
Merged

Added prn prescription #3288

merged 6 commits into from
Aug 27, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Aug 1, 2022 •
edited
Loading

closes #3194
closes #3301
image

@skks1212 skks1212 requested a review from a team August 1, 2022 10:29
@skks1212 skks1212 requested a review from a team as a code owner August 1, 2022 10:29
@skks1212 skks1212 requested a review from bodhish August 1, 2022 10:29
@netlify
Copy link

netlify bot commented Aug 1, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4c06097
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/630a40f9bc8d880008b35117
😎 Deploy Preview https://deploy-preview-3288--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Aug 9, 2022

@skks1212

image

  • dosage more than 2 decimals are been accepted, but in issue, it says up to 2 decimals only

image

  • when we are clicking on the increase and decrease button, the decimal inputted are been disappearing

@skks1212
Copy link
Member Author

@nihal467 I have not added any restriction just in case anyone would like to use any more decimals. Regarding number 2, that is a browser specific functionality, so it will always round it up to nearest 1s.

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@developedBySJ can you please rereview this one?

@khavinshankar khavinshankar added needs review merge conflict pull requests with merge conflict and removed needs review tested labels Aug 19, 2022
@skks1212 skks1212 added tested and removed merge conflict pull requests with merge conflict labels Aug 25, 2022
@skks1212 skks1212 removed the tested label Aug 27, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 27, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@nihal467
Copy link
Member

test approved

@gigincg gigincg merged commit 80e3910 into coronasafe:develop Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow decimals of dosage PRN Prescription
5 participants
@skks1212 @nihal467 @khavinshankar @gigincg @developedBySJ