Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable volunteer button when patient is discharged #3290

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 1, 2022

Related #3272
Related Backend Change: coronasafe/care#959

image

Note: This PR can be tested independent of the backend PR, it's just a supplementary.

@Ashesh3 Ashesh3 requested a review from a team August 1, 2022 16:09
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 1, 2022 16:09
@Ashesh3 Ashesh3 requested a review from giju August 1, 2022 16:09
@netlify
Copy link

netlify bot commented Aug 1, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8aba97b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/62f11f7e4dd48f0008f9896a
😎 Deploy Preview https://deploy-preview-3290--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2022

image

@Ashesh3 the error persist!

@Ashesh3
Copy link
Member Author

Ashesh3 commented Aug 7, 2022

@nihal467 This PR just disables the button to add new volunteer for discharged patient, the backend change fixing the issue (removing volunteer when discharged) is a separate PR, not related to this, coronasafe/care#959

@nihal467
Copy link
Member

nihal467 commented Aug 7, 2022

test approved

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar merged commit 7a947e1 into coronasafe:develop Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants