Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made all graph of Patient Dashboard responsive in mobile devices #3322

Merged
merged 8 commits into from
Sep 25, 2022
Merged

Made all graph of Patient Dashboard responsive in mobile devices #3322

merged 8 commits into from
Sep 25, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Aug 4, 2022 •
edited
Loading

Fixes #3273
Fixes #3348

Bugs Fixed

Made the ABG graph responsive in mobile devices

graphconsult

@patelaryan7751 patelaryan7751 requested a review from a team August 4, 2022 20:02
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner August 4, 2022 20:02
@netlify
Copy link

netlify bot commented Aug 4, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1983833
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/632e12906779c50009f4fb7c
😎 Deploy Preview https://deploy-preview-3322--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@developedBySJ
Copy link
Contributor

@patelaryan7751 Can you make other graphs(summery etc) responsive?

@patelaryan7751
Copy link
Contributor Author

@developedBySJ yeah sure 👍

@patelaryan7751 patelaryan7751 changed the title Made the ABG graph responsive in mobile devices Made all graph of Patient Dashboard responsive in mobile devices Aug 8, 2022
@patelaryan7751
Copy link
Contributor Author

@developedBySJ i have done the changes.

@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
18.2% 18.2% Duplication

developedBySJ
developedBySJ approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

nihal467 commented Aug 9, 2022

@patelaryan7751
image

the whole view is stretched,

@patelaryan7751
Copy link
Contributor Author

patelaryan7751 commented Aug 10, 2022 •
edited
Loading

Hey, @nihal467 please refresh the page after changing the media queries if you don't refresh you see this view.
Watch this video
https://www.loom.com/share/b5ca5836468f4e0e92b21174de709206

@nihal467
Copy link
Member

@patelaryan7751
image

consultation update in the medicine tab is making screen stretched

@patelaryan7751
Copy link
Contributor Author

Hey, @nihal467 I am not able to reproduce the stretch.
https://www.loom.com/share/962ab37aef5140d593fba45f33fb06be

@patelaryan7751 patelaryan7751 added needs testing question Further information is requested and removed test failed labels Aug 16, 2022
@nihal467 nihal467 removed the question Further information is requested label Aug 16, 2022
@nihal467
Copy link
Member

@patelaryan7751
image

file a consultation update in the medicine section in the critical care of a patient first. Then, check the reflection and you will see this error

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 can you provide the patient details where you facing the stretch ?

@patelaryan7751 patelaryan7751 added the question Further information is requested label Sep 12, 2022
@nihal467
Copy link
Member

@patelaryan7751 can you merge the latest development branch

@nihal467
Copy link
Member

nihal467 commented Sep 17, 2022 •
edited
Loading

@patelaryan7751

image

https://deploy-preview-3322--care-net.netlify.app/facility/bd466cf6-0fde-46b1-9591-0acf9d955dd1/patient/efe1db63-1d31-479d-ba42-d99cd609b634/consultation/486a1817-17a6-4b58-950e-ed70c7afb9c6/medicines, check this patient medicine

@nihal467
Copy link
Member

@patelaryan7751 merge the latest development branch and work on it ASAP

@sonarcloud
Copy link

sonarcloud bot commented Sep 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
21.1% 21.1% Duplication

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 i have fixed the bug
image

@patelaryan7751 patelaryan7751 added needs testing and removed question Further information is requested hold labels Sep 23, 2022
@nihal467
Copy link
Member

nihal467 commented Sep 24, 2022 •
edited
Loading

@patelaryan7751

image

  • the datas are not been shown completely

image

  • the icons are moved to right in the normal view, is it a intentional change

@nihal467
Copy link
Member

@patelaryan7751 @khavinshankar the above mentioned responsiveness issue will be taken as a separate PR, and khavin can you review this ASAP

@khavinshankar khavinshankar merged commit eb404fe into coronasafe:develop Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
needs testing urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make all graphs responsive in patient dashboard page in mobile devices Consultation Graph are unresponsive
5 participants
@patelaryan7751 @developedBySJ @nihal467 @Ashesh3 @khavinshankar