Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consultation navigation revamp #3378

Closed
wants to merge 3 commits into from
Closed

consultation navigation revamp #3378

wants to merge 3 commits into from

Conversation

arpancodes
Copy link
Contributor

Proposed Changes

fixes #2874

  • changed scrollable nav to a collapsable sidebar nav

Demo

nav-revamp

@coronasafe/reviewers

Merge Checklist

- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.

  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@arpancodes arpancodes self-assigned this Aug 11, 2022
@arpancodes arpancodes requested a review from a team August 11, 2022 21:49
@arpancodes arpancodes requested a review from a team as a code owner August 11, 2022 21:49
@netlify
Copy link

netlify bot commented Aug 11, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2e9b9b4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631f79ba48655a0008af71a8
😎 Deploy Preview https://deploy-preview-3378--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Aug 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@arpancodes was this revamping approach discussed in the EOD call or slack?

@nihal467 nihal467 added question Further information is requested Team Discuss Required and removed needs testing labels Aug 16, 2022
@nihal467
Copy link
Member

nihal467 commented Aug 23, 2022

@arpancodes team discussion tag is been used to know that, the particular UI is under discussion in our slack channel. Once, its completed, change it to need testing

@gigincg
Copy link
Member

gigincg commented Aug 23, 2022

@nihal467 @arpancodes Removing the discussion tab. As discussed over slack, let's have tabs with a "More" button based on screen-size.

On Mobile Screens, let's have Updates | Summary | Feed | More + as these are the most used tabs.

@gigincg gigincg added changes required and removed question Further information is requested needs review Team Discuss Required labels Aug 23, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 6, 2022
@github-actions
Copy link

github-actions bot commented Oct 6, 2022

👋 Hi, @arpancodes,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@stale
Copy link

stale bot commented Oct 14, 2022

Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2022
@github-actions
Copy link

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes required merge conflict pull requests with merge conflict stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Patient Consultation Page
3 participants