Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redirect to a common 404 page for invalid URLs. #3379

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Conversation

arpancodes
Copy link
Contributor

@arpancodes arpancodes commented Aug 11, 2022

fixes #2668

Proposed Changes

  • redirect to a common error page for the following
    • /facility/wrong-uid
    • /facility/:id/patient/:pid/consultation/wrong-uid
    • /assets/wrong-uid
    • /sample/wrong-uid
    • /resource/wrong-uid

@coronasafe/reviewers

Merge Checklist

- [ ] Add specs that demonstrate bug / test a new feature.
- [ ] Update product documentation.
- [ ] Ensure that UI text is kept in I18n files.

  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Screenshot

image

@arpancodes arpancodes self-assigned this Aug 11, 2022
@arpancodes arpancodes requested a review from a team August 11, 2022 23:00
@arpancodes arpancodes requested a review from a team as a code owner August 11, 2022 23:00
@netlify
Copy link

netlify bot commented Aug 11, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a2226b9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63070b5f777adc0009f8bf3b
😎 Deploy Preview https://deploy-preview-3379--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar added merge conflict pull requests with merge conflict and removed needs review labels Aug 25, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 89c9ef3 into develop Aug 25, 2022
@khavinshankar khavinshankar removed the merge conflict pull requests with merge conflict label Aug 25, 2022
@khavinshankar khavinshankar deleted the fix-2668 branch November 13, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When an incorrect URL is typed it should be redirected to Error Page
4 participants