Add validation for log update sliders #3389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
aeswibon
approved these changes
Aug 13, 2022
patelaryan7751
approved these changes
Aug 16, 2022
|
test approved |
There was a problem hiding this comment.
@Ashesh3 It seems we are repeating the same 2 functions in multiple files, so why don't you put them in a common file like utils.res or helpers.res and import the functions and use them?
and also instead of the names isInvalidInputInt and isInvalidInputFloat why not name it like isInputInRangeInt and isInputInRangeFloat, its upto you
|
@khavinshankar Thank you for the suggestions, I have implemented them. |
|
Kudos, SonarCloud Quality Gate passed!
|
khavinshankar
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2121
Adds validation to all the sliders of all sections.