Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor UI Fixes in Sample Management, Asset & Facility Pages #3415

Merged
merged 3 commits into from
Aug 25, 2022
Merged

Minor UI Fixes in Sample Management, Asset & Facility Pages #3415

merged 3 commits into from
Aug 25, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3414

  • Made Advanced filter button full width
    image

  • Made Set configuration button full width
    image

  • Improved spacing between buttons on facilities page
    image

@Pranshu1902 Pranshu1902 requested a review from a team August 16, 2022 07:20
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 16, 2022 07:20
@netlify
Copy link

netlify bot commented Aug 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit a52bbc4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63006e67332d280008413c70
😎 Deploy Preview https://deploy-preview-3415--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467 nihal467 changed the title Minor UI Fixes Minor UI Fixes in Sample Management & Facility Page Aug 16, 2022
@nihal467 nihal467 changed the title Minor UI Fixes in Sample Management & Facility Page Minor UI Fixes in Sample Management, Asset & Facility Pages Aug 16, 2022
@nihal467
Copy link
Member

@Pranshu1902
image

the notice button is not visible

@Pranshu1902
Copy link
Contributor Author

@nihal467
It is visible
image

developedBySJ
developedBySJ approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Aug 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 1c56e78 into coronasafe:develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@aeswibon aeswibon aeswibon approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI fixes in mobile view
5 participants
@Pranshu1902 @nihal467 @khavinshankar @developedBySJ @aeswibon