Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped Upload files buttons #3419

Closed
wants to merge 27 commits into from
Closed

Revamped Upload files buttons #3419

wants to merge 27 commits into from

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3418
http://localhost:4000/sample/f01568f0-3b58-418a-96fc-89d228073462

Made buttons full width for mobile view
image

@Pranshu1902 Pranshu1902 requested a review from a team August 17, 2022 05:38
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 17, 2022 05:38
@netlify
Copy link

netlify bot commented Aug 17, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b22b765
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635987fe8ba9090009ca26f7
😎 Deploy Preview https://deploy-preview-3419--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

developedBySJ
developedBySJ suggested changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Use tailwind buttons
  • Apply styles for the browse button

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Aug 20, 2022 •
edited
Loading

Updated Browse button view:
image

@netlify
Copy link

netlify bot commented Aug 20, 2022

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit d0f8561
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/63006ec8a161510009643d18

@nihal467
Copy link
Member

@Pranshu1902 is it good for testing

@nihal467 nihal467 added the question Further information is requested label Aug 23, 2022
@Pranshu1902
Copy link
Contributor Author

@Pranshu1902 is it good for testing

Yes

@Pranshu1902 Pranshu1902 removed the question Further information is requested label Aug 23, 2022
@nihal467
Copy link
Member

image

@Pranshu1902 test failed, check the button alignment in normal view

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@nihal467
Copy link
Member

@Pranshu1902
image

in responsive view, the buttons are not having gap in between them

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@nihal467
Copy link
Member

@Pranshu1902
image

in your PR buttons look bigger when compared to existing staging buttons, reduce the size of record, browse and upload buttons in to a way that, it is similar to all other buttons like discharge summary etc...

@Pranshu1902
Copy link
Contributor Author

@nihal467
Reduced buttons size
image

@nihal467
Copy link
Member

@Pranshu1902 the icons and text seem really big, can you discuss it in EOD, regarding this

@nihal467
Copy link
Member

@Pranshu1902
image

when you compared button icon and text size with other buttons, it is big, can you discuss this in EOD, to have a better solution

@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ❌ Failed (Inspect) Oct 26, 2022 at 7:19PM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Oct 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Pranshu1902
Copy link
Contributor Author

Fixed in #3363

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar left review comments

@Ashesh3 Ashesh3 Ashesh3 requested changes

@gigincg gigincg Awaiting requested review from gigincg

@developedBySJ developedBySJ Awaiting requested review from developedBySJ

Assignees
No one assigned
Labels
needs review work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Revamp Upload file buttons
5 participants
@Pranshu1902 @nihal467 @khavinshankar @Ashesh3 @developedBySJ