Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new dosage units #3439

Merged
merged 11 commits into from
Sep 21, 2022
Merged

Conversation

skks1212
Copy link
Member

closes #3438

@skks1212 skks1212 requested a review from a team August 19, 2022 20:05
@skks1212 skks1212 requested a review from a team as a code owner August 19, 2022 20:05
@skks1212 skks1212 requested a review from bodhish August 19, 2022 20:05
@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2c170e1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/632b336f86dfbe0008dbf0e3
😎 Deploy Preview https://deploy-preview-3439--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@skks1212

image

  • the Ampule is not able to see in normal view, you can decrease the dosage input box a little bit and we can able to see the ampule fully in normal view
  • check the responsivity of the whole page, after making the change
  • it would be great, if you can remove the " : " from the marked area along with this PR

@nihal467
Copy link
Member

@skks1212 check the merge conflict

@nihal467 nihal467 added merge conflict pull requests with merge conflict and removed needs testing labels Aug 29, 2022
@skks1212 skks1212 added needs testing and removed merge conflict pull requests with merge conflict labels Aug 30, 2022
@nihal467
Copy link
Member

@skks1212
image

unable to find ampule, as it was a unit mentioned in the issue to be added

@skks1212
Copy link
Member Author

skks1212 commented Sep 2, 2022

@nihal467 got messed up in solving merge conflicts, corrected now.

@nihal467
Copy link
Member

nihal467 commented Sep 6, 2022

@skks1212
image

  • unable to see the dosage inputted value in the responsive view

@skks1212
Copy link
Member Author

skks1212 commented Sep 7, 2022

@nihal467 I have tried to increase as much space as I can

@nihal467
Copy link
Member

@skks1212 can you merge the latest development branch !

@nihal467 nihal467 added the question Further information is requested label Sep 12, 2022
@skks1212 skks1212 removed the question Further information is requested label Sep 12, 2022
@nihal467
Copy link
Member

@skks1212
image

  • the UI is breaking in the normal view, but in the responsive view, it looks good.
  • check the failing cypress test

@nihal467 nihal467 added test failed Cypress Test Pending The Cypress test are to be verified and removed needs testing labels Sep 14, 2022
@skks1212
Copy link
Member Author

@nihal467 I have reverted the changes. A galaxy fold is an extremely thin device and everything is bound to break. The UI is responsive for all other sizes. If I make it responsive for this particular device everything else will break 😅

@skks1212 skks1212 added needs testing and removed Cypress Test Pending The Cypress test are to be verified test failed labels Sep 17, 2022
@nihal467
Copy link
Member

@skks1212
image

in the PRn description, it is not showing completely, can you adjust it and check the responsive of the same

@sonarcloud
Copy link

sonarcloud bot commented Sep 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 978a807 into coronasafe:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prescription: Dosage
4 participants