Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed Advice to General Instructions #3440

Merged
merged 2 commits into from
Sep 1, 2022
Merged

Renamed Advice to General Instructions #3440

merged 2 commits into from
Sep 1, 2022

Conversation

skks1212
Copy link
Member

closes #3436

@skks1212 skks1212 requested a review from a team August 19, 2022 20:12
@skks1212 skks1212 requested a review from a team as a code owner August 19, 2022 20:12
@netlify
Copy link

netlify bot commented Aug 19, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b5bb73c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63079c64c8f56e0009dc363f
😎 Deploy Preview https://deploy-preview-3440--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Aug 24, 2022 •
edited
Loading

@aparnacoronasafe

image

we should be changing here too right?

@nihal467 nihal467 added question Further information is requested tested and removed needs testing labels Aug 24, 2022
@aparnacoronasafe
Copy link
Member

@aparnacoronasafe

image

we should be changing here too right?

@nihal467 @skks1212

Yes. You need to make change suggested above by nihal too.

@nihal467 nihal467 added work-in-progress and removed question Further information is requested tested labels Aug 24, 2022
@sonarcloud
Copy link

sonarcloud bot commented Aug 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@nihal467
Copy link
Member

@skks1212
image

@aparnacoronasafe is this reflection okay or shall we make it General Instructions ( Advice ) as per issue

@nihal467 nihal467 added the question Further information is requested label Aug 29, 2022
@aparnacoronasafe
Copy link
Member

This is good. "general instructions"

@nihal467
Copy link
Member

test approved

@nihal467 nihal467 added tested and removed question Further information is requested needs testing labels Aug 30, 2022
@khavinshankar khavinshankar merged commit f20aef9 into coronasafe:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@aeswibon aeswibon aeswibon approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advice: Consultation
5 participants
@skks1212 @nihal467 @aparnacoronasafe @khavinshankar @aeswibon