Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed UI issues on Assets and External Results page #3472

Merged
merged 3 commits into from
Sep 1, 2022
Merged

Fixed UI issues on Assets and External Results page #3472

merged 3 commits into from
Sep 1, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3471

@Pranshu1902 Pranshu1902 requested a review from a team August 25, 2022 07:30
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner August 25, 2022 07:30
@netlify
Copy link

netlify bot commented Aug 25, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6afa71e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631067062adb81000857cfec
😎 Deploy Preview https://deploy-preview-3472--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

test approved

Ashesh3
Ashesh3 approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Components/Assets/AssetsList.tsx Outdated Show resolved Hide resolved
Pranshu1902 and others added 2 commits August 31, 2022 18:26
@Pranshu1902 @Ashesh3
Update src/Components/Assets/AssetsList.tsx
ee8edfd 
Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com>
@khavinshankar
Merge branch 'develop' into issue#3471
6afa71e
@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.7% 6.7% Duplication

@khavinshankar khavinshankar merged commit a9b5c19 into coronasafe:develop Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@aeswibon aeswibon aeswibon approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI Fixes on Assets and External Results page
5 participants
@Pranshu1902 @nihal467 @Ashesh3 @khavinshankar @aeswibon