Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed badge gaps and padding, also made changes to assets block #3487

Merged
merged 5 commits into from
Sep 8, 2022

Conversation

skks1212
Copy link
Member

closes #3486

before :
image

after :
image

@skks1212 skks1212 requested a review from a team August 27, 2022 11:41
@skks1212 skks1212 requested a review from a team as a code owner August 27, 2022 11:41
@netlify
Copy link

netlify bot commented Aug 27, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 55f5c7a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6315d7508b27440008e65ff9
😎 Deploy Preview https://deploy-preview-3487--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@skks1212
image

in big screen, it is creating a big space

image

in responsive view, the badges are not having space in between them

@skks1212
Copy link
Member Author

@nihal467 changes made 👍

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@skks1212 can you please checkout the merge conflict and also check if the ui is disturbed after merging?

@khavinshankar khavinshankar added the merge conflict pull requests with merge conflict label Sep 1, 2022
@skks1212 skks1212 removed the merge conflict pull requests with merge conflict label Sep 2, 2022
@nihal467 nihal467 added Cypress Test Pending The Cypress test are to be verified and removed tested labels Sep 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@nihal467 nihal467 added the tested label Sep 5, 2022
@nihal467
Copy link
Member

nihal467 commented Sep 5, 2022

@skks1212 check the cypress, it is failed

@skks1212
Copy link
Member Author

skks1212 commented Sep 7, 2022

@skks1212 check the cypress, it is failed

@nihal467 tests appear to be improperly configured...

@khavinshankar khavinshankar merged commit 7b2aae8 into coronasafe:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cypress Test Pending The Cypress test are to be verified tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve badges UI in assets page
3 participants