Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made Bed No. Badges Consistent #3490

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Made Bed No. Badges Consistent #3490

merged 2 commits into from
Sep 8, 2022

Conversation

GokulramGHV
Copy link
Member

@GokulramGHV GokulramGHV commented Aug 27, 2022 •
edited
Loading

Fixes #3476

Proposed Changes

  • Added location to the badge
  • Used same styling from patient list

Preview:
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@GokulramGHV GokulramGHV requested a review from a team August 27, 2022 13:51
@GokulramGHV GokulramGHV requested a review from a team as a code owner August 27, 2022 13:51
@netlify
Copy link

netlify bot commented Aug 27, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 354675e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631305781c52590008460e56
😎 Deploy Preview https://deploy-preview-3490--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Aug 30, 2022 •
edited
Loading

@GokulramGHV https://deploy-preview-3490--care-net.netlify.app/facility/3447b03d-7522-4525-9e14-58d7628b1e9e/patient/446e058b-dfc3-48cf-bb1f-51c722bb8695/consultation/9cbe100d-6251-4439-9b46-b9b64ec10d5e

image

  • make it center aligned and make the text inside the box
  • make the switch bed button aligned to the badges on the right side, as in our existing UI

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@GokulramGHV
Copy link
Member Author

@nihal467
Is this okay?
image

@nihal467 nihal467 mentioned this pull request Sep 3, 2022
Closed
@nihal467
Copy link
Member

nihal467 commented Sep 6, 2022 •
edited
Loading

@GokulramGHV Looks good to me, approved

@khavinshankar khavinshankar merged commit d0c6406 into coronasafe:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bed No. Badges: Consistancy
3 participants
@GokulramGHV @nihal467 @khavinshankar