Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bed badge alignment #3503

Merged
merged 2 commits into from
Sep 8, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Aug 29, 2022

Fixes #3497

image

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team August 29, 2022 18:33
@Ashesh3 Ashesh3 requested a review from a team as a code owner August 29, 2022 18:33
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4c85cba
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6312f016a092e80008cd4f53
😎 Deploy Preview https://deploy-preview-3503--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Aug 31, 2022

@Ashesh3
image

Even though ensuring every data is inside the box, the UI is breaking the uniformity.

  • keep the UI Uniform itself, and anything is not fitting inside the box, hide the additional overflowing data and when anyone hovers over the box, then only they can see the full data

@sonarcloud
Copy link

sonarcloud bot commented Sep 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 3, 2022

Made the changes.

image

On hover:
msedge_b7bxCFuqe2

@nihal467
Copy link
Member

nihal467 commented Sep 6, 2022

test approved

@khavinshankar khavinshankar merged commit 623b57f into coronasafe:develop Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Bed badge allignment
3 participants