Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesigned minQtyList #3533

Merged
merged 4 commits into from
Sep 21, 2022
Merged

Redesigned minQtyList #3533

merged 4 commits into from
Sep 21, 2022

Conversation

GokulramGHV
Copy link
Member

fixes #3531

Proposed Changes

  • Redesigned the Min Quantity list page
  • made both the buttons ( set and cancel ) in different row

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@GokulramGHV GokulramGHV requested a review from a team September 3, 2022 18:07
@GokulramGHV GokulramGHV requested a review from a team as a code owner September 3, 2022 18:07
@netlify
Copy link

netlify bot commented Sep 3, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c52f2e9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/631e2d8a59e0d90008fd8d4e
😎 Deploy Preview https://deploy-preview-3533--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rabilrbl
rabilrbl suggested changes Sep 5, 2022
View reviewed changes
Copy link
Contributor

@rabilrbl rabilrbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The UI is not updated for set min quantity: here
image

@GokulramGHV
Copy link
Member Author

@nihal467

image

@sonarcloud
Copy link

sonarcloud bot commented Sep 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar
Copy link
Member

@nihal467 the cypress tests seemed to have failed, shall i still merge it?

@khavinshankar khavinshankar added question Further information is requested and removed good to merge labels Sep 14, 2022
@nihal467
Copy link
Member

@GokulramGHV check the cypress test, it is failing

@nihal467 nihal467 added Cypress Test Pending The Cypress test are to be verified and removed question Further information is requested labels Sep 14, 2022
@nihal467
Copy link
Member

@khavinshankar we will merge it, once the cypress is fixed

@khavinshankar khavinshankar merged commit fbdbf7d into coronasafe:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@rabilrbl rabilrbl rabilrbl approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
Cypress Test Pending The Cypress test are to be verified good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Responsive UI change in Minimum Quantity Required Page at Facility Inventory
4 participants
@GokulramGHV @nihal467 @khavinshankar @rabilrbl