Store Asset details URL in QR code #3551
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
👋 Hi, @Ashesh3, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
No longer required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #3480
Blocking PR: coronasafe/dashboard#205
This PR modifies the data stored in the QR code generated on Asset page. The QR now stores the asset details page's url for the particular asset displayed on the care dashboard.
The QR when scanned externally should now link to a page where the user can view the details of the asset publicly.
If the QR is scanned from within the care platform, it redirects to the asset's page just like before.
Asset page on
care_fe:Asset QR scanned from an external scanner:
Asset QR scanned from "Scan Asset QR" page in
care_fe: