Fix crash when feature's id is missing from feature_types

[Ashesh3]

Fix #3552

The search results page crashes when a facility has a feature whose id is not mapped in the FACILITY_FEATURE_TYPES. This PR adds a safe check for existence before accessing the feature's properties.

[netlify]

✅ Deploy Preview for care-egov-staging ready!

Name	Link
🔨 Latest commit	467dbd3
🔍 Latest deploy log	https://app.netlify.com/sites/care-egov-staging/deploys/63184c19894af0000aa825af
😎 Deploy Preview	https://deploy-preview-3553--care-egov-staging.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site settings.

[nihal467]

@Ashesh3 https://deploy-preview-3553--care-net.netlify.app/facility/dbfac015-0556-4450-8435-20bf3d97bc14

now, the search got ready, but when the facility button is clicked, it is crashing there, can you check indetail

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
1.1% Duplication

[Ashesh3]

@nihal467 Should be fixed now. Somehow the facility "test-nihal-001" has a feature which doesn't exist (ID 6). This shouldn't be possible as the frontend has no option to set a feature with ID 6 during asset creation. Maybe there needs to be checks on the backend to disallow such invalid values.

[khavinshankar]

@Ashesh3 can you please raise an issue about this in the backend?

[Ashesh3]

@Ashesh3 can you please raise an issue about this in the backend?

Sure!

[Ashesh3]

@khavinshankar The backend does have proper validation for feature ids.

This issue seemed to be due to an inconsistency between the features mapping on the backend and frontend.

Backend:

 FEATURE_CHOICES = [
    (1, "CT Scan Facility"),
    (2, "Maternity Care"),
    (3, "X-Ray facility"),
    (4, "Neonatal care"),
    (5, "Operation theater"),
    (6, "Blood Bank"),
]

Frontend:

export const FACILITY_FEATURE_TYPES = [
  {
    id: 1,
    name: "CT Scan",
    icon: "circle-dot",
  },
  {
    id: 2,
    name: "Maternity Care",
    icon: "person-breastfeeding",
  },
  {
    id: 3,
    name: "X-Ray",
    icon: "x-ray",
  },
  {
    id: 4,
    name: "Neonatal Care",
    icon: "baby",
  },
  {
    id: 5,
    name: "Operation Theater",
    icon: "syringe",
  },
];

Feature "Blood Bank" with id 6 has not been added to the frontend yet.

Issue (Addition of Blood Bank): #3469

The below two PRs ideally should have been merged together:
Backend change: coronasafe/care#993
Frontend change: #3474

But it seems that the backend change was merged but the frontend lagged behind, which caused this issue.

[nihal467]

@Ashesh3 @khavinshankar it is working now, do we need this PR or close it?

[Ashesh3]

@Ashesh3 @khavinshankar it is working now, do we need this PR or close it?

We still need this PR to fix it, This adds a conditional check to not print attributes which do not exist. This should make the care platform more robust and crash proof. This will ensure that crashes do not happen in future even if backend and frontend are not in sync (which is the case currently even now).