Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Patient Category in Daily Rounds and Consultation #3565

Merged
merged 3 commits into from
Sep 15, 2022

Conversation

rithviknishad
Copy link
Member

Functional changes as per #2210
Colors and styling updates will be made once #3458 is merged.

Proposed Changes

  • Adds mandatory patient category field in Patient Consultation form.
    image

  • Adds mandatory patient category field in Daily Rounds form.
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team September 9, 2022 13:57
@rithviknishad rithviknishad requested a review from a team as a code owner September 9, 2022 13:57
@netlify
Copy link

netlify bot commented Sep 9, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 0f41d35
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6321fbf6857da0000b48efa0
😎 Deploy Preview https://deploy-preview-3565--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad
Copy link
Member Author

Requires backend PR ohcnetwork/care#1007

@nihal467
Copy link
Member

@rithviknishad merge the latest development branch and is it waiting for the backend to merge, if yes, remove need testing and label it as waiting for backend

@nihal467 nihal467 added the question Further information is requested label Sep 12, 2022
@rithviknishad
Copy link
Member Author

A minor bug was fixed, ready for testing. @nihal467

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@rithviknishad can you check the cypress test and other than that, PR looks good

@nihal467 nihal467 added tested Cypress Test Pending The Cypress test are to be verified and removed needs testing labels Sep 14, 2022
@khavinshankar
Copy link
Member

@rithviknishad please do check out the failing cypress test

@rithviknishad
Copy link
Member Author

@khavinshankar @nihal467 all tests are passing when I ran cypress locally (with Staging BE).

Workflow cypress is failing in many due to 403s.

image

@rithviknishad rithviknishad removed the Cypress Test Pending The Cypress test are to be verified label Sep 15, 2022
@khavinshankar khavinshankar merged commit 3d43afc into ohcnetwork:develop Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants