Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed 'updated at' from asset card #3569

Merged
merged 2 commits into from
Sep 21, 2022
Merged

Removed 'updated at' from asset card #3569

merged 2 commits into from
Sep 21, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 10, 2022 •
edited
Loading

Fixes #3563

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team September 10, 2022 14:30
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 10, 2022 14:30
@netlify
Copy link

netlify bot commented Sep 10, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7473e86
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6321db0d1da267000908af2f
😎 Deploy Preview https://deploy-preview-3569--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

test approved

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.9% 0.9% Duplication

@khavinshankar
Copy link
Member

@Ashesh3 can you please check out failing cypress tests

@khavinshankar khavinshankar added the Cypress Test Pending The Cypress test are to be verified label Sep 15, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 15, 2022

@Ashesh3 can you please check out failing cypress tests

Hey, the tests failing are an issue with the cypress configuration itself and @vigneshhari told us to completely ignore all Cypress tests, till they are fixed (I quote, "pretend they don't exist"). Even then, I've manually checked the tests and the failing components have nothing to do with the changes in this PR.

developedBySJ
developedBySJ approved these changes Sep 16, 2022
View reviewed changes
Copy link
Contributor

@developedBySJ developedBySJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar added good to merge and removed Cypress Test Pending The Cypress test are to be verified labels Sep 19, 2022
@khavinshankar khavinshankar merged commit 01b47a8 into ohcnetwork:develop Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@developedBySJ developedBySJ developedBySJ approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
good to merge peer-reviewed tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove the Updated at Data from the Asset Card in the Page
5 participants
@Ashesh3 @nihal467 @khavinshankar @rithviknishad @developedBySJ