Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new waveforms #3575

Merged
merged 4 commits into from
Sep 19, 2022
Merged

Added new waveforms #3575

merged 4 commits into from
Sep 19, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Sep 12, 2022 •
edited
Loading

image
Added 2 new waveforms

@skks1212 skks1212 requested a review from a team September 12, 2022 16:38
@skks1212 skks1212 requested a review from a team as a code owner September 12, 2022 16:38
@netlify
Copy link

netlify bot commented Sep 12, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b8ef926
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6321dbc188e47d000860048e
😎 Deploy Preview https://deploy-preview-3575--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@skks1212

  • what is the issue, i can't find anything linked to it,
  • cypress is also failing

@nihal467 nihal467 added the question Further information is requested label Sep 14, 2022
@skks1212 skks1212 removed the question Further information is requested label Sep 14, 2022
@skks1212
Copy link
Member Author

@nihal467 I have added more information to the PR

@nihal467
Copy link
Member

nihal467 commented Sep 14, 2022 •
edited
Loading

@skks1212
image

  • unable to see the data, when we are hovering over it ( Pulse Rate )
  • Does Pulse rate and pleth are the same?
  • Does SPO2 and II are the same?

image

  • why are waveform breaking, when we are initially opening it up

@nihal467 nihal467 added work-in-progress question Further information is requested and removed needs testing labels Sep 14, 2022
@skks1212 skks1212 added needs testing and removed question Further information is requested labels Sep 14, 2022
@nihal467
Copy link
Member

@skks1212 reply to my comment and check the cypress too !

@skks1212
Copy link
Member Author

@nihal467 this PR will still need more changes. Sorry to bother you 😅. Will remove work in progress once issues have been resolved!

@sonarcloud
Copy link

sonarcloud bot commented Sep 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@skks1212
Copy link
Member Author

@nihal467 Please test now. Cypress tests are breaking because of network timeouts (backend is rate limiting requests most probably)

@gigincg gigincg merged commit 3dc3026 into coronasafe:develop Sep 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rabilrbl rabilrbl rabilrbl approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
None yet
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skks1212 @nihal467 @rabilrbl @gigincg