Added validation to onvif and hl7monitor asset pages #3586
Conversation
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@developedBySJ i have implemented useReducer hook |
|
Hey @developedBySJ i have refractored the code |
|
when i click save link button, iam getting both the notification, so can we add a validation there , for both monitor and camera page, is it possible |
|
@nihal467 yeah sure it can be done. |
|
Hey @nihal467 i have done the changes Camera configure page
MonitorConfigure page
|
|
test approved |
|
Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions. |
|
Hey @khavinshankar i have done the changes. |
| asset?.asset_class, | ||
| asset?.meta?.middleware_hostname, | ||
| asset?.meta?.local_ip_address |
There was a problem hiding this comment.
| asset?.asset_class, | |
| asset?.meta?.middleware_hostname, | |
| asset?.meta?.local_ip_address | |
| asset?.asset_class || "", | |
| asset?.meta?.middleware_hostname || "", | |
| asset?.meta?.local_ip_address || "" |
| asset?.asset_class, | ||
| asset?.meta?.middleware_hostname, | ||
| asset?.meta?.local_ip_address, | ||
| asset?.meta?.camera_access_key |
There was a problem hiding this comment.
| asset?.asset_class, | |
| asset?.meta?.middleware_hostname, | |
| asset?.meta?.local_ip_address, | |
| asset?.meta?.camera_access_key | |
| asset?.asset_class || "", | |
| asset?.meta?.middleware_hostname || "", | |
| asset?.meta?.local_ip_address || "", | |
| asset?.meta?.camera_access_key || "" |
| case "middlewareHostname": | ||
| if (!state.form[field] || state.form[field].trim() === "") { | ||
| errors[field] = "Field is required"; | ||
| invalidForm = true; | ||
| } | ||
| return; | ||
| case "cameraAccessKey": | ||
| if (!state.form[field] || state.form[field].trim() === "") { | ||
| errors[field] = "Field is required"; | ||
| invalidForm = true; | ||
| } | ||
| return; |
There was a problem hiding this comment.
| case "middlewareHostname": | |
| if (!state.form[field] || state.form[field].trim() === "") { | |
| errors[field] = "Field is required"; | |
| invalidForm = true; | |
| } | |
| return; | |
| case "cameraAccessKey": | |
| if (!state.form[field] || state.form[field].trim() === "") { | |
| errors[field] = "Field is required"; | |
| invalidForm = true; | |
| } | |
| return; | |
| case "middlewareHostname": | |
| case "cameraAccessKey": | |
| if (!state.form[field] || state.form[field].trim() === "") { | |
| errors[field] = "Field is required"; | |
| invalidForm = true; | |
| } | |
| return; |
|
@patelaryan7751 just some minor refactors here and there |
|
👋 Hi, @patelaryan7751, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
SonarCloud Quality Gate failed.
|
|
👋 Hi, @patelaryan7751, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
|
I am openning a fresh PR for this issue |
Proposed Changes
Fixes #3585
Added validation to onvif and hl7monitor asset pages
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist