Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revamped medicines section of the patient dashboard #3613

Merged
merged 5 commits into from
Oct 6, 2022
Merged

Revamped medicines section of the patient dashboard #3613

merged 5 commits into from
Oct 6, 2022

Conversation

GokulramGHV
Copy link
Member

Fixes #3508

Proposed Changes

  • Changed all the heading like ( Route, Frequency, etc... ) and related data color to black
  • Made the page responsive and added a new table view on smalller screen sizes
  • Made the consultation update and prescription into the same alignment

Screenshots

chrome_ToD93R71Ek

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team September 19, 2022 12:47
@GokulramGHV GokulramGHV requested a review from a team as a code owner September 19, 2022 12:47
@netlify
Copy link

netlify bot commented Sep 19, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 016d2d7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633bb9d71118b700090ef053
😎 Deploy Preview https://deploy-preview-3613--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mathew-alex mathew-alex added the merge conflict pull requests with merge conflict label Sep 27, 2022
@mathew-alex
Copy link
Contributor

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

Ashesh3
Ashesh3 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. By the way, there's a Merge Conflict here!

@GokulramGHV GokulramGHV added needs testing and removed work-in-progress merge conflict pull requests with merge conflict labels Oct 4, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@GokulramGHV is this design approved by @gigincg and @aparnacoronasafe

@nihal467 nihal467 added the question Further information is requested label Oct 4, 2022
@nihal467
Copy link
Member

nihal467 commented Oct 5, 2022

test approved

@nihal467 nihal467 added tested and removed question Further information is requested needs testing labels Oct 5, 2022
@khavinshankar khavinshankar merged commit a4fdfbe into ohcnetwork:develop Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Improvement in the Consultation Update under the medicine section
5 participants
@GokulramGHV @mathew-alex @nihal467 @Ashesh3 @khavinshankar