Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make user's last seen responsive #3623

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Sep 22, 2022

Fixes #3621

users

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team September 22, 2022 08:30
@Ashesh3 Ashesh3 requested a review from a team as a code owner September 22, 2022 08:30
@netlify
Copy link

netlify bot commented Sep 22, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2d17f93
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/632c1d29b696c8000899e6a0
😎 Deploy Preview https://deploy-preview-3623--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

Copy link
Contributor

@patelaryan7751 patelaryan7751 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nihal467
Copy link
Member

@Ashesh3
image

the last seen in coming down in the normal view, is it intentional

@nihal467 nihal467 added the question Further information is requested label Sep 27, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Sep 27, 2022

@Ashesh3 image

the last seen in coming down in the normal view, is it intentional

Yes, that'll only happen if it can't fit the whole last seen on the same line, in rare cases of "extremely long usernames". So instead of clipping it'd shift it to the next line. All depends on the screen size and username length.

@Ashesh3 Ashesh3 removed the question Further information is requested label Sep 27, 2022
@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 98e93dc into coronasafe:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Last seen in the user management page is overflowing
5 participants