Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: parent url when clicking back icon #3637

Merged
merged 8 commits into from
Feb 9, 2023
Merged

fix: parent url when clicking back icon #3637

merged 8 commits into from
Feb 9, 2023

Conversation

Pragati1610
Copy link
Contributor

fixes #2737

@Pragati1610 Pragati1610 requested a review from a team September 24, 2022 10:26
@Pragati1610 Pragati1610 requested a review from a team as a code owner September 24, 2022 10:26
@netlify
Copy link

netlify bot commented Sep 24, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d9f8678
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63e3a7dc275df900078900e3
😎 Deploy Preview https://deploy-preview-3637--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes Sep 24, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if it's an update or create operation in asset form and facility form and accordingly set back url

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@rithviknishad can you review this again

@nihal467 nihal467 added the question Further information is requested label Oct 4, 2022
@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@Pragati1610 once the work is completed and rereviewed, mark it for need testing

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 11, 2022
@github-actions
Copy link

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@stale
Copy link

stale bot commented Oct 18, 2022

Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 18, 2022
@github-actions github-actions bot removed the stale label Oct 20, 2022
@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 20, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 30, 2022
@github-actions
Copy link

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@vercel
Copy link

vercel bot commented Oct 31, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 8, 2023 at 1:49PM (UTC)

@Pragati1610 Pragati1610 removed question Further information is requested work-in-progress labels Oct 31, 2022
@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Feb 5, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023

@Pragati1610 check the deploy preview and make it ready for testing , and change the label

@nihal467 nihal467 added the stale label Feb 6, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 6, 2023

@khavinshankar can you review it

@nihal467 nihal467 added the P2 label Feb 6, 2023
@github-actions github-actions bot removed stale merge conflict pull requests with merge conflict labels Feb 7, 2023
@Pragati1610 Pragati1610 added needs testing and removed test failed Deploy-Failed Deplyment is not showing preview labels Feb 8, 2023
@khavinshankar
Copy link
Member

@rithviknishad can u rereview this

rithviknishad
rithviknishad approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khavinshankar @Pragati1610 LGTM

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Feb 8, 2023
@github-actions
Copy link

github-actions bot commented Feb 8, 2023

👋 Hi, @Pragati1610,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Feb 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Feb 8, 2023

@khavinshankar can you review it

@khavinshankar khavinshankar merged commit 196413c into ohcnetwork:develop Feb 9, 2023
@rithviknishad rithviknishad mentioned this pull request Feb 9, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
needs review needs testing P2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pressing back takes you back, but not where you expect...
4 participants
@Pragati1610 @nihal467 @khavinshankar @rithviknishad