Made 'Treatment Summary' page responsive #3643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
test approved |
|
@GokulramGHV any update |
|
@nihal467 The PR is ready.. I saw @khavinshankar's question just now and I've replied to it |
There was a problem hiding this comment.
@GokulramGHV have you tried out print: from tailwind, this is actually easy to use
Ashesh3
approved these changes
Oct 2, 2022
There was a problem hiding this comment.
Looks good, but following @khavinshankar 's suggestion and using the print modifier from Tailwind instead of clsx would really make the code better, we should generally avoid clsx where possible (Vignesh's words).
|
Kudos, SonarCloud Quality Gate passed!
|
|
test approved |
khavinshankar
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3605
Proposed Changes
Screenshot
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist