Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed name of the label Active to transfer status: active in asset page #3647

Closed
wants to merge 5 commits into from
Closed

Changed name of the label Active to transfer status: active in asset page #3647

wants to merge 5 commits into from

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Sep 26, 2022 •
edited
Loading

Proposed Changes

Fixes #3646
Changed name of the label Active to transfer status: active in asset page as discussed in eod
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team September 26, 2022 07:36
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner September 26, 2022 07:36
@netlify
Copy link

netlify bot commented Sep 26, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e3aa5bd
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633a8518fe1867000806b3a5
😎 Deploy Preview https://deploy-preview-3647--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@patelaryan7751
image
can we have it same row, rather than two row

@nihal467 nihal467 added question Further information is requested work-in-progress and removed question Further information is requested needs testing labels Sep 27, 2022
Ashesh3
Ashesh3 approved these changes Oct 2, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but personally, for me, adding the whole term "Transfer Status: " makes the badge look bulky. Is there any better way we can achieve the same effect? Maybe something like how we have on the Patient's page?

image

@patelaryan7751
Copy link
Contributor Author

Hey @Ashesh3 @nihal467 is this okay ?
image

@sonarcloud
Copy link

sonarcloud bot commented Oct 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Ashesh3
Ashesh3 approved these changes Oct 3, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me!

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@patelaryan7751
image

when the not working badge comes it, in become two row, can we do anything about it

@nihal467 nihal467 added the question Further information is requested label Oct 4, 2022
rithviknishad
rithviknishad requested changes Oct 5, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have consistent casing for the badges too?

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2022

@patelaryan7751 once the work is completed, change it to need testing

@stale
Copy link

stale bot commented Oct 14, 2022

Hi, This pr/issue has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs for 7 more days. Thank you for your contributions.

@stale stale bot added the stale label Oct 14, 2022
@patelaryan7751
Copy link
Contributor Author

patelaryan7751 commented Oct 16, 2022 •
edited
Loading

This issue would be disscussed in next eod and resolved in next eod.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 24, 2022
@github-actions
Copy link

github-actions bot commented Nov 1, 2022

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@aeswibon aeswibon aeswibon approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
question Further information is requested stale work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change Active label to Transfer Status : Active in Asstes Page
5 participants
@patelaryan7751 @nihal467 @Ashesh3 @rithviknishad @aeswibon