Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the live feed responsive in samsung fold device #3648

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Sep 26, 2022

Proposed Changes

Fixes #3589
Made the live feed responsive in samsung fold device
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 1b7aea0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6331624b3751b70008acd9ed
😎 Deploy Preview https://deploy-preview-3648--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @patelaryan7751, let's try to stick to the tailwind as much as possible, rather than using useMediaQuery from material UI, try this https://tailwindcss.com/docs/screens. I'm merging this pr, so feel free to create a new pr for the above issue, nice work Aryan

@khavinshankar khavinshankar merged commit fbe2b2b into coronasafe:develop Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Onvif camera asset page not responsive in samsung fold device
3 participants