Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added bell icon to Notification modal subscribe button #3651

Merged
merged 2 commits into from
Sep 29, 2022

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

Fixes #3650
added bell icon to Notification modal subscribe button
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team September 26, 2022 23:28
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner September 26, 2022 23:28
@netlify
Copy link

netlify bot commented Sep 26, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9edb56d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6333eaaf95a8cf0008229140
😎 Deploy Preview https://deploy-preview-3651--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@patelaryan7751
image

can you add a icon to subscribe also, to make it uniform

@nihal467 nihal467 added the question Further information is requested label Sep 27, 2022
@patelaryan7751
Copy link
Contributor Author

@nihal467 the icon is added

@patelaryan7751 patelaryan7751 removed the question Further information is requested label Sep 27, 2022
@nihal467
Copy link
Member

@patelaryan7751 push the changes, i can't see its reflection

@nihal467 nihal467 added the question Further information is requested label Sep 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Sep 28, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 i have added the icon
Screenshot_2022-09-28-12-19-53-92_40deb401b9ffe8e1df2f1cc5ba480b12.jpg

@nihal467
Copy link
Member

test approved

@nihal467 nihal467 added tested and removed question Further information is requested needs testing labels Sep 29, 2022
@khavinshankar khavinshankar merged commit 793dbad into coronasafe:develop Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Minor Ui enhancement : Add a bell icon to subscribe button in notification modal
3 participants