Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes: Add Health Details in Consultation form #3698

Closed
wants to merge 13 commits into from
Closed

Fixes: Add Health Details in Consultation form #3698

wants to merge 13 commits into from

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 3, 2022

@aeswibon
* Integrate health details API
2e1777b 
* Migrated fields from patient registration to patient consultation form
* Added new fields from API
* Formatted the code
@aeswibon
Updated blood_group field logic and added height,weight validation
b492f9c
@aeswibon
Removed health details API fields from patient registration form
263fbd2
@netlify
Copy link

netlify bot commented Oct 3, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e138cb9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6350030e121e1d00086bcac5
😎 Deploy Preview https://deploy-preview-3698--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad
Copy link
Member

😢 thats a major change im gonna face in my consultation form tailwind update. I'll keep my PRs for (#3698 #3594) on hold until this is merged.

@aeswibon aeswibon marked this pull request as ready for review October 5, 2022 06:42
@aeswibon aeswibon requested a review from a team October 5, 2022 06:42
@aeswibon aeswibon requested a review from a team as a code owner October 5, 2022 06:42
@aeswibon aeswibon added hacktoberfest needs testing Major Code Change This Tag represent PR, which will be causing major Code change in the platform labels Oct 5, 2022
@aeswibon aeswibon mentioned this pull request Oct 8, 2022
Closed
rithviknishad
rithviknishad requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cp-Coder is it ready?
when I click Edit Consultation, I get a blank screen:

image

@rithviknishad
Copy link
Member

Oh my bad... Backend is required too.

@rithviknishad rithviknishad mentioned this pull request Oct 9, 2022
Closed
@github-actions
Copy link

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 12, 2022
@aeswibon aeswibon removed the merge conflict pull requests with merge conflict label Oct 12, 2022
@aeswibon
* Added Medical history API components
e138cb9 
* Added new fields to consultation model
* Created DiseaseBuilder component
* Modified VaccinationBuilder component
@sonarcloud
Copy link

sonarcloud bot commented Oct 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 21, 2022
@github-actions
Copy link

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon closed this Oct 22, 2022
@aeswibon aeswibon deleted the issue#2738 branch October 22, 2022 05:00
@aeswibon
Copy link
Member Author

Will open a new PR squashing all the commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
hacktoberfest Major Code Change This Tag represent PR, which will be causing major Code change in the platform merge conflict pull requests with merge conflict work-in-progress
Projects
None yet
Milestone
No milestone
2 participants
@aeswibon @rithviknishad