Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UI on assets page #3704

Merged
merged 5 commits into from
Oct 11, 2022
Merged

Improved UI on assets page #3704

merged 5 commits into from
Oct 11, 2022

Conversation

Pranshu1902
Copy link
Contributor

Fixes #3703

@Pranshu1902 Pranshu1902 requested a review from a team October 4, 2022 07:03
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner October 4, 2022 07:03
@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 6e19455
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/633bdac9fd8e83000891ca4b
😎 Deploy Preview https://deploy-preview-3704--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 4, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 16f54ab
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63455bff5146ab00084c3b84
😎 Deploy Preview https://deploy-preview-3704--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Oct 4, 2022

@rithviknishad can you review this

@nihal467
Copy link
Member

nihal467 commented Oct 5, 2022

@Pranshu1902
image

the icon and the asset name are in two lines, but in existing staging, they are in single line. Is it an intentional change !

@nihal467 nihal467 added the question Further information is requested label Oct 5, 2022
@Pranshu1902
Copy link
Contributor Author

@nihal467
It was unintentional, reverted to the previous style
image

@Pranshu1902 Pranshu1902 removed the question Further information is requested label Oct 6, 2022
@nihal467
Copy link
Member

@Pranshu1902
image

why the icons colour is changed to black,

@Pranshu1902
Copy link
Contributor Author

@nihal467 It was an unintended change
Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit ace1eff into coronasafe:develop Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add truncate on assets page and improve badges spacing
5 participants
@Pranshu1902 @nihal467 @Ashesh3 @rithviknishad @khavinshankar