Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed: Minor UI change in the asset page #3733

Merged
merged 2 commits into from
Oct 13, 2022
Merged

Fixed: Minor UI change in the asset page #3733

merged 2 commits into from
Oct 13, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Oct 9, 2022

Updates

@aeswibon aeswibon requested a review from a team October 9, 2022 06:06
@aeswibon aeswibon requested a review from a team as a code owner October 9, 2022 06:06
@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 68e5cf0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6345b07acd0119000aeedc44
😎 Deploy Preview https://deploy-preview-3733--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@aeswibon aeswibon mentioned this pull request Oct 9, 2022
Closed
3 tasks
Ashesh3
Ashesh3 approved these changes Oct 10, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rithviknishad
rithviknishad approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR has not changed the number of cards listed on the asset page though. The grid just changed from 6x4 to 8x3.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

test approved

@khavinshankar khavinshankar merged commit 43c9a8d into coronasafe:develop Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
hacktoberfest tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor UI change in the asset page
5 participants
@aeswibon @nihal467 @Ashesh3 @rithviknishad @khavinshankar