Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix patient category selection #3741

Merged
merged 6 commits into from
Oct 13, 2022
Merged

Fix patient category selection #3741

merged 6 commits into from
Oct 13, 2022

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 10, 2022

Fixes #3729

  • Fixes the category value to match with the backend, this resolves the error where the category value is an invalid choice.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team October 10, 2022 11:22
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 10, 2022 11:22
@Ashesh3 Ashesh3 requested a review from gigincg October 10, 2022 11:22
@netlify
Copy link

netlify bot commented Oct 10, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fae1ec5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6347aa03ffd2c700093dcb2e
😎 Deploy Preview https://deploy-preview-3741--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad
Copy link
Member

rithviknishad commented Oct 11, 2022 •
edited
Loading

@Ashesh3 three things:

  • Consultation updates for "Slightly Abnormal" and "Comfort Care" not working.
  • New log updates page not working.
  • Edit log updates not working.
2022-10-11.14-16-28.mp4

rithviknishad
rithviknishad requested changes Oct 11, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made in PATIENT_CATEGORIES constants need to be updated on log updates page, and also fix the consultation update not working for "Comfort Care" and "Slightly Abnormal"

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 11, 2022 •
edited
Loading

@Ashesh3 three things:

  • Consultation updates for "Slightly Abnormal" and "Comfort Care" not working.
  • New log updates page not working.
  • Edit log updates not working.

2022-10-11.14-16-28.mp4

Should be fixed now.

@nihal467
Copy link
Member

test approved

khavinshankar
khavinshankar approved these changes Oct 13, 2022
View reviewed changes
src/Components/Facility/ConsultationForm.tsx Outdated Show resolved Hide resolved
src/Components/Patient/DailyRounds.tsx Outdated Show resolved Hide resolved
src/Components/Patient/DailyRounds.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
1.6% 1.6% Duplication

@khavinshankar khavinshankar merged commit 284c919 into coronasafe:develop Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient Category Filters for "Comfort Care" and "Slightly Abnormal" not working.
4 participants
@Ashesh3 @rithviknishad @nihal467 @khavinshankar