Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed minor UI break in Facility Page #3755

Closed
wants to merge 15 commits into from

Conversation

siddnikh
Copy link
Contributor

Changed font color of phone number (earlier blue) and added phone icon beside it.
Was supposed to fix issue #3713 but I figured green colour would look better for a clickable link rather than black. Please feel free to suggest something that would look better.

@siddnikh siddnikh requested a review from a team October 14, 2022 09:22
@siddnikh siddnikh requested a review from a team as a code owner October 14, 2022 09:22
@netlify
Copy link

netlify bot commented Oct 14, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit db6d8c8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63492a4d2ce40a0009409ea8
😎 Deploy Preview https://deploy-preview-3755--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@siddnikh siddnikh self-assigned this Oct 14, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@nihal467
Copy link
Member

nihal467 commented Oct 26, 2022

@siddnikh
image

this doesn't look good to me, still take an opinion from gigin and aparna in the EOD call, once it finalised and approved, mark it for need testing

@nihal467 nihal467 added the hold label Nov 1, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022

@siddnikh @rithviknishad @khavinshankar @gigincg the whole facility page is getting redesigned #3755 , so putting this PR on hold

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 9, 2022
@github-actions
Copy link

👋 Hi, @siddnikh,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added merge conflict pull requests with merge conflict and removed stale labels Nov 17, 2022
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 15, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants