Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added patient search by IP number #3761

Merged
merged 3 commits into from
Oct 26, 2022
Merged

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Oct 15, 2022

Resolves #3749

Proposed Changes

  • Reorganized the patient search and filtering section
  • Added a search field to find a patient by the IP number
  • Moved the "Select a 7-day period" to a tooltip

msedge_1qu7zEeFE3

image

msedge_HQeDG1udpC

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team October 15, 2022 20:44
@Ashesh3 Ashesh3 requested a review from a team as a code owner October 15, 2022 20:44
@Ashesh3 Ashesh3 requested a review from gigincg October 15, 2022 20:44
@netlify
Copy link

netlify bot commented Oct 15, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f168458
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635395515fcd250008403152
😎 Deploy Preview https://deploy-preview-3761--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Oct 20, 2022

@Ashesh3
image

the add details of a patient button is not aligned to the other text boxes, can you make it aligned

image

make the badges left aligned

@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 21, 2022

Fixed.
image

image

image

@nihal467
Copy link
Member

@Ashesh3
image

the white spacing in the page, still look weird, can you take this issue in the EOD call, to have a better approach to this issue

@nihal467 nihal467 added the question Further information is requested label Oct 21, 2022
@Ashesh3
Copy link
Member Author

Ashesh3 commented Oct 22, 2022

@nihal467 After discussion with Aparna, this is the finalized design:

image

I've made the changes to reflect the new design.

@Ashesh3 Ashesh3 removed the question Further information is requested label Oct 22, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.4% 1.4% Duplication

@nihal467
Copy link
Member

test approved

Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khavinshankar khavinshankar merged commit 2f09f63 into coronasafe:develop Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Patient Search: IP No.
3 participants