Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Waveform Refresh Mode #3768

Merged
merged 13 commits into from
Nov 10, 2022
Merged

Waveform Refresh Mode #3768

merged 13 commits into from
Nov 10, 2022

Conversation

skks1212
Copy link
Member

Added refresh mode to Waveform

@netlify
Copy link

netlify bot commented Oct 16, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c0c4450
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636c668612930300085f9bb8
😎 Deploy Preview https://deploy-preview-3768--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@skks1212 skks1212 changed the title Waveform 3 Waveform Refresh Mode Oct 16, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 17, 2022
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Oct 19, 2022
@github-actions
Copy link

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Oct 20, 2022
@skks1212 skks1212 marked this pull request as ready for review October 20, 2022 19:22
@skks1212 skks1212 requested a review from a team October 20, 2022 19:22
@skks1212 skks1212 requested a review from a team as a code owner October 20, 2022 19:22
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Oct 28, 2022
@vercel
Copy link

vercel bot commented Nov 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 10, 2022 at 2:50AM (UTC)

@github-actions github-actions bot removed merge conflict pull requests with merge conflict stale labels Nov 1, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

@skks1212
image

https://deploy-preview-3768--care-net.netlify.app/facility/c4911f55-d4f7-4b36-bbcb-9b115d1bfe2c/patient/88986c19-3ab5-4820-b35d-7b7d95ac4f00/consultation/4f80a4cb-ed21-4b8f-95fd-b9c3a74e851e

the wave is keep on breaking.

@gigincg
Copy link
Member

gigincg commented Nov 8, 2022

@nihal467 This is expected behaviour.

@nihal467 nihal467 added the P1 breaking issue or vital feature label Nov 8, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022 •
edited
Loading

@skks1212 @gigincg

https://screen-recorder-bucket.s3.ap-south-1.amazonaws.com/ScreenRecorder_2022-11-09_c8bf154b-9a7c-4ec1-9acc-06cbb966748a.mp4

  • there is a shivering in the vital, which doesn't look great at all

the waveform is good is normal view and responsive view. After todays EOD, will finalise the approval status of the PR

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

conditionally approving it, the existing issue will be made a new pr

@nihal467 nihal467 added the tested label Nov 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 10, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.5% 0.5% Duplication

@khavinshankar khavinshankar merged commit 47becbc into coronasafe:develop Nov 10, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@skks1212 @aeswibon
Waveform Refresh Mode (coronasafe#3768)
3fa5aee 
* stuff

* made refresh mode

* made changes

* bypassed settimeout restraint

* speed improvements

* number errors

* switched from initial null array from 0

* fix grid bug for other waveforms

* remove console log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
Care
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skks1212 @nihal467 @gigincg @khavinshankar