Minor UI enhacement in Patients page for extreme small devices and some ranges #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
test approved |
khavinshankar
approved these changes
Oct 20, 2022
khavinshankar
added a commit
that referenced
this pull request
Oct 22, 2022
* Create main.yml * Fix main.yml errors * Update main.yml * Update and rename main.yml to merge_upstream.yml * Update merge_upstream.yml * Update merge_upstream.yml * Refactor cypress workflow - Change to ubuntu-latest - Switch to npm from yarn - Give appropriate names for each step in workflow * Fix patient crud error on Add Patient button * Remove accidentally added workflow * Delete stale.yml (#3782) * feat: added github stale action (#3785) * Made the teleicuvitalcard responsive (#3669) * Made TeleViatlsCard responsive * Minor enhancement * fix buggy redirect after clicking on cancel button in add more bed types (#3710) * fix buggy redirect after clicking on cancel button in add more bed types * fix: deepscan issues * Update packages and remove obsolete dependencies (#3748) * Remove nonessential packages * Update packages having a minor version change * Add back autoprefixer * Fix for google maps * Change error message for offline camera (#3789) * Minor UI enhacement in Patients page for extreme small devices and some ranges (#3779) * Use `Inter` font as the sans font (#3683) * Adds `Inter` as sans font * fix overweighted font usages * correct font weights * correct font weights * Fix login page title overflow * Adds fallback to `sans-serif` Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Update src/style/index.css Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * fix syntax * fix typo Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Patient Category Colors (#3728) * patient category type * show category in patient list page * move colors to tailwind config for app wide access * category on info card * fix issue with classes skipped from build * category on patient profile * patient info card, move category above patient photo * Revert "patient info card, move category above patient photo" This reverts commit 9dc5d55. * Patient Review feature fixes (#3584) * Add review_interval and review badges * Change label to Review before * Update src/Components/Patient/DailyRounds.tsx Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> * Upgrade cypress to v10.10.0 * Fix Error in facility create with adding doctor * Fix `parseInt` parameter error in patient crud * Add emojis Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> Co-authored-by: ARYAN PATEL <patelaryan7751@gmail.com> Co-authored-by: Pragati Bhattad <55177805+Pragati1610@users.noreply.github.com> Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com> Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
rithviknishad
added a commit
to rithviknishad/care_fe
that referenced
this pull request
Oct 22, 2022
* Create main.yml * Fix main.yml errors * Update main.yml * Update and rename main.yml to merge_upstream.yml * Update merge_upstream.yml * Update merge_upstream.yml * Refactor cypress workflow - Change to ubuntu-latest - Switch to npm from yarn - Give appropriate names for each step in workflow * Fix patient crud error on Add Patient button * Remove accidentally added workflow * Delete stale.yml (coronasafe#3782) * feat: added github stale action (coronasafe#3785) * Made the teleicuvitalcard responsive (coronasafe#3669) * Made TeleViatlsCard responsive * Minor enhancement * fix buggy redirect after clicking on cancel button in add more bed types (coronasafe#3710) * fix buggy redirect after clicking on cancel button in add more bed types * fix: deepscan issues * Update packages and remove obsolete dependencies (coronasafe#3748) * Remove nonessential packages * Update packages having a minor version change * Add back autoprefixer * Fix for google maps * Change error message for offline camera (coronasafe#3789) * Minor UI enhacement in Patients page for extreme small devices and some ranges (coronasafe#3779) * Use `Inter` font as the sans font (coronasafe#3683) * Adds `Inter` as sans font * fix overweighted font usages * correct font weights * correct font weights * Fix login page title overflow * Adds fallback to `sans-serif` Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Update src/style/index.css Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * fix syntax * fix typo Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Patient Category Colors (coronasafe#3728) * patient category type * show category in patient list page * move colors to tailwind config for app wide access * category on info card * fix issue with classes skipped from build * category on patient profile * patient info card, move category above patient photo * Revert "patient info card, move category above patient photo" This reverts commit 9dc5d55. * Patient Review feature fixes (coronasafe#3584) * Add review_interval and review badges * Change label to Review before * Update src/Components/Patient/DailyRounds.tsx Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> * Upgrade cypress to v10.10.0 * Fix Error in facility create with adding doctor * Fix `parseInt` parameter error in patient crud * Add emojis Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> Co-authored-by: ARYAN PATEL <patelaryan7751@gmail.com> Co-authored-by: Pragati Bhattad <55177805+Pragati1610@users.noreply.github.com> Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com> Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
khavinshankar
added a commit
that referenced
this pull request
Oct 26, 2022
* tailwind colors as per figma * implement select menu with new interface * use select menu v2 for ordering * update tailwind colors as per figma * facility types * support option value * gender * gender icons * is antenatal field * kasp * category * disease status * vaccinated * declared * telemedicine * top buttons * persistent filter buttons * update color pallete as per figma * import form fields from consultation redesign PR * consume new text input * remove range * fix * `npx init storybook` * update `@storybook/preset-create-react-app` * install storybook postcss for tailwind * fix issues with tailwind and reload * fix magically value prop gone missing * `npm install tw-elements` * Rename new to `SelectMenuV2` * add tw-elements to package lock file * implements multi select menu * last admitted to bed type * remove unused code * imporve select menus * update placeholder colors * show chips below multi select * consistent `form-input`, `form-textarea` styling * wip, to let khavin try * Revert "add tw-elements to package lock file" This reverts commit eba6368. * revert `tw-elements` for datepicker * add `serve-storybook` * fix colors as per figma color scheme * implements basic buttons * update button styles * button shape circle as boolean attribute * update filter buttons * fix button styling when `circle` * remove comments * feat: added custom AutoCompleteAsync component * Merge `package-lock.json` of `develop` to tailwind/storybook * `npm install --legacy-peer-deps` post merge `develop` to tailwind/storybook * storybook: remove default stories * eslint: ignore '*.stories.mdx' files * storybook: add-on `storybook-dark-mode` * button stories * add DateInputV2 and DateRangeInputV2 * make datepicker css consistent * fix (AutoCompleteAsync): fixed debounce issue * ui (AsyncAutoComplete): changed bg color * refactor out `DropdownMenuTransition` for consistent experience across all dropdown components * add validators * fix validator issue * update field validators * DateFormField and DateRangeFormField wrappers * use consistent transition for date picker as used in other components * fix typo * fix datepicker focus issue, by wrapping it with Popover * replace material icons with font awesom * fix asyncautocomplete field placeholder color * storybook: fontawesome and inter font scripts * storybook: DateFormField * storybook: text area and text form fields * fix styling issue with phone input * rename `ButtonStyle` to `ButtonVariant` * storybook: complete button story * fix property error missing issue * storybook: `SelectMenuV2` * storybook: `MultiSelectMenuV2` * storybook: move care ui elements to care ui dir * fix title * select year in datepicker * disable increment year btn * Patient Review feature fixes (#3584) * Add review_interval and review badges * Change label to Review before * Update src/Components/Patient/DailyRounds.tsx Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> * Keep loading spinner during redirect (#3754) * Cypress: Fixes & Refactoring (#3798) * Create main.yml * Fix main.yml errors * Update main.yml * Update and rename main.yml to merge_upstream.yml * Update merge_upstream.yml * Update merge_upstream.yml * Refactor cypress workflow - Change to ubuntu-latest - Switch to npm from yarn - Give appropriate names for each step in workflow * Fix patient crud error on Add Patient button * Remove accidentally added workflow * Delete stale.yml (#3782) * feat: added github stale action (#3785) * Made the teleicuvitalcard responsive (#3669) * Made TeleViatlsCard responsive * Minor enhancement * fix buggy redirect after clicking on cancel button in add more bed types (#3710) * fix buggy redirect after clicking on cancel button in add more bed types * fix: deepscan issues * Update packages and remove obsolete dependencies (#3748) * Remove nonessential packages * Update packages having a minor version change * Add back autoprefixer * Fix for google maps * Change error message for offline camera (#3789) * Minor UI enhacement in Patients page for extreme small devices and some ranges (#3779) * Use `Inter` font as the sans font (#3683) * Adds `Inter` as sans font * fix overweighted font usages * correct font weights * correct font weights * Fix login page title overflow * Adds fallback to `sans-serif` Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Update src/style/index.css Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * fix syntax * fix typo Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * Patient Category Colors (#3728) * patient category type * show category in patient list page * move colors to tailwind config for app wide access * category on info card * fix issue with classes skipped from build * category on patient profile * patient info card, move category above patient photo * Revert "patient info card, move category above patient photo" This reverts commit 9dc5d55. * Patient Review feature fixes (#3584) * Add review_interval and review badges * Change label to Review before * Update src/Components/Patient/DailyRounds.tsx Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> * Upgrade cypress to v10.10.0 * Fix Error in facility create with adding doctor * Fix `parseInt` parameter error in patient crud * Add emojis Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> Co-authored-by: ARYAN PATEL <patelaryan7751@gmail.com> Co-authored-by: Pragati Bhattad <55177805+Pragati1610@users.noreply.github.com> Co-authored-by: Ashesh <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Rithvik Nishad <rithvikn2001@gmail.com> Co-authored-by: Bodhish Thomas <bodhish@gmail.com> * `AutoCompleteAsync` fix `multiple` overload type * fix (AutoCompleteAsync): fixed input issue Co-authored-by: Ashesh3 <3626859+Ashesh3@users.noreply.github.com> Co-authored-by: Khavin Shankar <khavinshankar@gmail.com> Co-authored-by: Ritesh-Aggarwal <riteshaggarwal2001@gmail.com> Co-authored-by: Mohammed Rabil <63334479+rabilrbl@users.noreply.github.com> Co-authored-by: ARYAN PATEL <patelaryan7751@gmail.com> Co-authored-by: Pragati Bhattad <55177805+Pragati1610@users.noreply.github.com> Co-authored-by: Bodhish Thomas <bodhish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #3764
Before
View in extreme small devices
View in range of 768px to 900px
View in range of 1025px to 1220px
After
It should look like this in extreme small devices
It should look like this in range of 768px to 900px
It should look like this in range of 1025px to 1220px
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist