Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: misalignment of No Assets Found text #3801

Merged
merged 4 commits into from
Nov 3, 2022
Merged

fix: misalignment of No Assets Found text #3801

merged 4 commits into from
Nov 3, 2022

Conversation

aeswibon
Copy link
Member

Updates

@aeswibon aeswibon requested a review from a team October 22, 2022 09:17
@aeswibon aeswibon requested a review from a team as a code owner October 22, 2022 09:17
@netlify
Copy link

netlify bot commented Oct 22, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d5a0e87
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636331dc9737500008d0de6a
😎 Deploy Preview https://deploy-preview-3801--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Ashesh3
Ashesh3 approved these changes Oct 23, 2022
View reviewed changes
Copy link
Member

@Ashesh3 Ashesh3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I believe it'd be better if we could make it similar to the no results text on the sample test page.

image

@nihal467
Copy link
Member

@cp-Coder i can see a comment of ashesh once it completed, mark it as need testing

@vercel
Copy link

vercel bot commented Oct 26, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 3:15AM (UTC)

@khavinshankar
Copy link
Member

@rithviknishad can you check out the vercel error

@rithviknishad
Copy link
Member

@khavinshankar can be ignored, or merge the latest develop for the storybook.
Storybook is currently not there in this branch, that's why deploy is failing.

@nihal467
Copy link
Member

@cp-Coder
image

the white box should be streched like all other page

@netlify
Copy link

netlify bot commented Oct 30, 2022

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 044c65a
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/635e2a06920b87000871080c

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022 •
edited
Loading

@cp-Coder
image

the icons are not visible in your PR and in staging, it is working fine

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

test approved

@khavinshankar khavinshankar merged commit c1c0578 into ohcnetwork:develop Nov 3, 2022
aeswibon added a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@aeswibon
fix: misalignment of No Assets Found text (ohcnetwork#3801)
885935c 
* fix (AssetList): fixed alignment of No asset Found text

* style(assetList): center aligned the text

* chore(master): rebase the develop branch

* fix(assetList): added icons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ashesh3 Ashesh3 Ashesh3 approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
hacktoberfest tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No Asset Found text is misaligned in asset page
5 participants
@aeswibon @nihal467 @khavinshankar @rithviknishad @Ashesh3