Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed null issue in review_interval in DailyRounds #3815

Merged
merged 3 commits into from
Oct 25, 2022
Merged

Conversation

khavinshankar
Copy link
Member

Fixed #3814

Proposed Changes

  • Fixed null issue in review_interval in DailyRounds

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar requested a review from a team October 24, 2022 02:35
@khavinshankar khavinshankar requested a review from a team as a code owner October 24, 2022 02:35
@netlify
Copy link

netlify bot commented Oct 24, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9c424b8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6356bbd13bff7100093dae4e
😎 Deploy Preview https://deploy-preview-3815--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Oct 24, 2022

@khavinshankar
image

  • when i readmit a patient, the review time are been taken from old consultation and copied to the new consultation page

image
image

  • even though iam not mentioning any review time, after submission of log update, the review time is set to the time of submission and the patient is tagged review missed

@khavinshankar
Copy link
Member Author

@nihal467 In the above-mentioned issues, the first will be fixed in the pr for coronasafe/care#1075, and the second one should already be fixed

@nihal467
Copy link
Member

@khavinshankar waiting for the backend

@sonarcloud
Copy link

sonarcloud bot commented Oct 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@gigincg gigincg merged commit 14b24c2 into develop Oct 25, 2022
@khavinshankar khavinshankar deleted the fix#3814 branch November 13, 2022 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to file log update without setting review time
3 participants