Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login page revamp #3853

Merged
merged 11 commits into from
Nov 3, 2022
Merged

Login page revamp #3853

merged 11 commits into from
Nov 3, 2022

Conversation

skks1212
Copy link
Member

@skks1212 skks1212 commented Oct 28, 2022 •
edited
Loading

after:
image
image

before:
image

@skks1212 skks1212 requested a review from a team October 28, 2022 20:40
@skks1212 skks1212 requested a review from a team as a code owner October 28, 2022 20:40
@vercel
Copy link

vercel bot commented Oct 28, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 3:09PM (UTC)

@netlify
Copy link

netlify bot commented Oct 28, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 15be4b6
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6363d9587f638a0009f3bec9
😎 Deploy Preview https://deploy-preview-3853--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 28, 2022

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 76e7eac
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/635c3e49cc0374000968765f

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022

@skks1212 @khavinshankar

  • i can seen a comment by github code scan bot, can you guys look into it
  • in tamil and malayalam, the text are overlapping in the login page
    image

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022 •
edited
Loading

@skks1212 @khavinshankar marking it for team discussion required

  • to discuss on the final approval of the design in the EOD call

@github-actions
Copy link

github-actions bot commented Nov 2, 2022

👋 Hi, @skks1212,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 2, 2022
@skks1212 skks1212 added needs testing and removed work-in-progress merge conflict pull requests with merge conflict labels Nov 2, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

@skks1212
image

  • in the forget password page, when i click on top of the "username" text in the box, the input field is not coming up.
  • the send reset link button is not functioning

rithviknishad
rithviknishad requested changes Nov 3, 2022
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skks1212 could you fix the forget password validation logic?

@skks1212
Copy link
Member Author

skks1212 commented Nov 3, 2022

@skks1212 could you fix the forget password validation logic?

Already fixed 😬

@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.5% 0.5% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

test approved

@khavinshankar khavinshankar merged commit c552583 into coronasafe:develop Nov 3, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@skks1212 @aeswibon
Login page revamp (coronasafe#3853)
1777ec4 
* Login page revamp

* fixed language selector

* responsiveness and final touches

* done

* added forgot password

* shifted coronasafe logo, changed urls

* minor changes

* minor changes 2

* fixed bugs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad requested changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@skks1212 @nihal467 @rithviknishad @khavinshankar