Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix phone input style and tailwind user filters #3863

Merged
merged 3 commits into from
Oct 29, 2022
Merged

fix phone input style and tailwind user filters #3863

merged 3 commits into from
Oct 29, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Oct 29, 2022 •
edited
Loading

Resolves #3855
Resolves #3869

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team October 29, 2022 07:51
@rithviknishad rithviknishad requested a review from a team as a code owner October 29, 2022 07:51
@vercel
Copy link

vercel bot commented Oct 29, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 1:59PM (UTC)

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature labels Oct 29, 2022
@netlify
Copy link

netlify bot commented Oct 29, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 69399c7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/635d316587193a0009fc49f7
😎 Deploy Preview https://deploy-preview-3863--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad changed the title fix phone input style fix phone input style and tailwind user filters Oct 29, 2022
@rithviknishad rithviknishad added work-in-progress and removed needs testing P1 breaking issue or vital feature labels Oct 29, 2022
@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature redesign and removed work-in-progress labels Oct 29, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@rithviknishad
image
does adding grey in the background in intentional !

@nihal467 nihal467 added the question Further information is requested label Oct 29, 2022
@nihal467
Copy link
Member

test approved

@nihal467 nihal467 added tested and removed question Further information is requested needs testing labels Oct 29, 2022
@khavinshankar khavinshankar merged commit 2eb430b into coronasafe:develop Oct 29, 2022
@rithviknishad rithviknishad mentioned this pull request Oct 29, 2022
Closed
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rithviknishad @aeswibon
fix phone input style and tailwind user filters (coronasafe#3863)
9c7560d 
* fix phone input

* redesign filters

* fix spacing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
P1 breaking issue or vital feature redesign tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User management filters are malfunctioning Unable to view the full Phone number in the patient creation form
3 participants
@rithviknishad @nihal467 @khavinshankar