Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress: Refactor waits in api requests #3900

Merged
merged 4 commits into from
Nov 1, 2022
Merged

Cypress: Refactor waits in api requests #3900

merged 4 commits into from
Nov 1, 2022

Conversation

rabilrbl
Copy link
Contributor

@rabilrbl rabilrbl commented Oct 31, 2022

Resolves #3750

Proposed Changes

  • Change all hard-coded wait(x) for api requests with intercept-wait.
  • Minor additions in some spec test

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@rabilrbl rabilrbl requested a review from a team October 31, 2022 23:23
@rabilrbl rabilrbl requested a review from a team as a code owner October 31, 2022 23:23
@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 1, 2022 at 8:31AM (UTC)

@netlify
Copy link

netlify bot commented Oct 31, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit c339b7a
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6360d90744a40600080d0d98
😎 Deploy Preview https://deploy-preview-3900--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 1, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.1% 10.1% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022

@khavinshankar can you check this issue

@khavinshankar khavinshankar merged commit 966b364 into coronasafe:develop Nov 1, 2022
@rabilrbl rabilrbl deleted the Cypress/AddTests branch November 1, 2022 17:16
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
* Add minor tests for health details

* Refactor Waits in Cypress (coronasafe#3750)

* Remove commented spec tests in shifting filters

* Bump cypress to
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Waits in Cypress
3 participants