Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show dropdown list over mui modal in LinkFacilityDialog #3906

Merged
merged 7 commits into from
Nov 3, 2022
Merged

Show dropdown list over mui modal in LinkFacilityDialog #3906

merged 7 commits into from
Nov 3, 2022

Conversation

khavinshankar
Copy link
Member

Proposed Changes

  • Show dropdown list over mui modal in LinkFacilityDialog
    image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

This is a mui-specific issue, making our own custom Modal and replacing it instead of mui Dialog should solve this

@khavinshankar khavinshankar requested a review from a team November 1, 2022 10:02
@khavinshankar khavinshankar requested a review from a team as a code owner November 1, 2022 10:02
@vercel
Copy link

vercel bot commented Nov 1, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 3, 2022 at 10:00AM (UTC)

@netlify
Copy link

netlify bot commented Nov 1, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9183c37
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636390f1396b24000862e569
😎 Deploy Preview https://deploy-preview-3906--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@khavinshankar khavinshankar self-assigned this Nov 1, 2022
@khavinshankar khavinshankar added needs testing P1 breaking issue or vital feature labels Nov 1, 2022
@khavinshankar
Copy link
Member Author

Fixes #3904

@nihal467
Copy link
Member

nihal467 commented Nov 1, 2022

@khavinshankar
image

when we click outside the droplist, the list should be closing,

@khavinshankar
Copy link
Member Author

@nihal467 can you try this in the incognito tab

@nihal467
Copy link
Member

nihal467 commented Nov 2, 2022

@khavinshankar
image

when we click on the place where cross is marked, the droplist is not closing

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 2, 2022
@github-actions
Copy link

github-actions bot commented Nov 3, 2022

👋 Hi, @khavinshankar,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 3, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

@khavinshankar check the merge conflict

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Nov 3, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot removed the cypress failed pull request with cypress test failure label Nov 3, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

test approved

@gigincg gigincg merged commit 285901c into develop Nov 3, 2022
@khavinshankar khavinshankar mentioned this pull request Nov 8, 2022
Closed
@khavinshankar khavinshankar deleted the fix#3904 branch November 13, 2022 06:04
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@khavinshankar @aeswibon
Show dropdown list over mui modal in LinkFacilityDialog (coronasafe#3906
0744f4c 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees

@khavinshankar khavinshankar

Labels
P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@khavinshankar @nihal467 @gigincg