Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patient's dashboard breadcrumbs 🍞 fixed ✅ #3926

Merged
merged 2 commits into from
Nov 3, 2022
Merged

Patient's dashboard breadcrumbs 🍞 fixed ✅ #3926

merged 2 commits into from
Nov 3, 2022

Conversation

ishanExtreme
Copy link
Contributor

@ishanExtreme ishanExtreme commented Nov 2, 2022 •
edited
Loading

Issue Fixed

fixes #3923

Updates

  • FacilityId is replaced with facilityName.
  • PatientId is replaced with patientName.
  • ConsultationId is replaced with "facilityName - patientName"

Demo

Screenshot 2022-11-02 at 12 33 56 PM

New update

Replaced consultaion ID with admission date

Screenshot 2022-11-02 at 11 31 20 PM

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@ishanExtreme ishanExtreme requested a review from a team November 2, 2022 07:13
@ishanExtreme ishanExtreme requested a review from a team as a code owner November 2, 2022 07:13
@vercel
Copy link

vercel bot commented Nov 2, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 6:01PM (UTC)

@netlify
Copy link

netlify bot commented Nov 2, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 966676d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6362affbabe7fb000b2d6424
😎 Deploy Preview https://deploy-preview-3926--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

@ishanExtreme is it good for testing, i can see a push even after the PR is marked as need testing

@nihal467 nihal467 added the question Further information is requested label Nov 3, 2022
@ishanExtreme
Copy link
Contributor Author

@nihal467 Yup its good for testing, another commit I made was after yesterday's EOD, where gigin discussed to change consultation id to admission date.

@nihal467
Copy link
Member

nihal467 commented Nov 3, 2022

LGTM

@nihal467 nihal467 added tested and removed question Further information is requested needs testing labels Nov 3, 2022
@khavinshankar khavinshankar merged commit b0dbe0c into coronasafe:develop Nov 3, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@ishanExtreme @aeswibon
Patient's dashboard breadcrumbs 🍞 fixed ✅ (coronasafe#3926)
7b24459 
* Patient's dashboard breadcrumbs fixed

* consultation id replaced with admission date

Co-authored-by: Ishan Mishra <ishanmishra@Ishans-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix patient's dashboard breadcrumbs link.
3 participants
@ishanExtreme @nihal467 @khavinshankar