Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes issues in Facility Card's layout and minor UI tweaks #3959

Merged
merged 14 commits into from
Dec 1, 2022
Merged

Fixes issues in Facility Card's layout and minor UI tweaks #3959

merged 14 commits into from
Dec 1, 2022

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Nov 5, 2022 •
edited
Loading

Proposed Changes

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team November 5, 2022 06:29
@rithviknishad rithviknishad requested a review from a team as a code owner November 5, 2022 06:29
@netlify
Copy link

netlify bot commented Nov 5, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ab413bb
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63876b1338e7cd0008c2c8d6
😎 Deploy Preview https://deploy-preview-3959--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 5, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 30, 2022 at 2:41PM (UTC)

rithviknishad
rithviknishad commented Nov 5, 2022
View reviewed changes
Copy link
Member Author

@rithviknishad rithviknishad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only changes made were:

  1. class h-fit was conflicting with h-full, but in the end h-fit got priority, so removed it.
    image

  2. Refactored out the whole card to a named component: FacilityCard.

@nihal467
Copy link
Member

nihal467 commented Nov 9, 2022

@rithviknishad
image

the facility buttons are missing, in responsive view

@rithviknishad rithviknishad changed the title Fixes facility card layout spacing issue below the action buttons bar FIxes issues in Facility Card's layout Nov 9, 2022
@rithviknishad rithviknishad changed the title FIxes issues in Facility Card's layout Fixes issues in Facility Card's layout Nov 9, 2022
@rithviknishad rithviknishad changed the title Fixes issues in Facility Card's layout Fixes issues in Facility Card's layout and minor UI tweaks Nov 9, 2022
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 17, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Nov 18, 2022
@netlify
Copy link

netlify bot commented Nov 18, 2022

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit e58204a
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/637718da6117da0009328b52

@rithviknishad rithviknishad mentioned this pull request Nov 18, 2022
Closed
@nihal467
Copy link
Member

@rithviknishad the deployment is failed

@nihal467 nihal467 added Deploy-Failed Deplyment is not showing preview and removed needs testing labels Nov 21, 2022
@rithviknishad rithviknishad added needs testing and removed Deploy-Failed Deplyment is not showing preview labels Nov 28, 2022
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Nov 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad removed the merge conflict pull requests with merge conflict label Nov 30, 2022
@nihal467
Copy link
Member

nihal467 commented Dec 1, 2022

LGTM

@khavinshankar khavinshankar merged commit 0212915 into coronasafe:develop Dec 1, 2022
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 7, 2022
@rithviknishad @aeswibon
Fixes issues in Facility Card's layout and minor UI tweaks (coronasaf…
64db6f8 
…e#3959)

* fix#3954

* set max height for cover image in mobile view

* fix layout spacing issue

* use new button for facility card

* minor ui tweaks

* reduces the effect of translation of shadow button variant

* remove translate on hover
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@rithviknishad @aeswibon
Fixes issues in Facility Card's layout and minor UI tweaks (coronasaf…
057016b 
…e#3959)

* fix#3954

* set max height for cover image in mobile view

* fix layout spacing issue

* use new button for facility card

* minor ui tweaks

* reduces the effect of translation of shadow button variant

* remove translate on hover
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
needs review tested
Projects
None yet
Milestone
No milestone
3 participants
@rithviknishad @nihal467 @khavinshankar