Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed selection issue in Prescription Builder #3962

Merged
merged 1 commit into from
Nov 5, 2022
Merged

Fixed selection issue in Prescription Builder #3962

merged 1 commit into from
Nov 5, 2022

Conversation

khavinshankar
Copy link
Member

@khavinshankar khavinshankar commented Nov 5, 2022

Fixes #3960

Proposed Changes

  • Changed default compareBy to undefined from "id" in AutoCompleteAsync
  • Added compareBy property to other instances

As in prescriptions we were passing string instead of objects there was no need for compareBy prop

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar added needs testing P1 breaking issue or vital feature labels Nov 5, 2022
@khavinshankar khavinshankar requested a review from a team November 5, 2022 10:00
@khavinshankar khavinshankar requested a review from a team as a code owner November 5, 2022 10:00
@netlify
Copy link

netlify bot commented Nov 5, 2022

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7e51591
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63663424df62500008cc64b6
😎 Deploy Preview https://deploy-preview-3962--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Nov 5, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 5, 2022 at 10:00AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 5, 2022
@nihal467
Copy link
Member

nihal467 commented Nov 5, 2022

test approved

@gigincg gigincg merged commit 7bff735 into develop Nov 5, 2022
@khavinshankar khavinshankar deleted the fix#3960 branch November 13, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRN prescription and prescription are malfunctioning
3 participants