Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cypress): Cypress test are failing locally #3974

Merged
merged 4 commits into from
Nov 9, 2022
Merged

fix(cypress): Cypress test are failing locally #3974

merged 4 commits into from
Nov 9, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Nov 6, 2022 •
edited
Loading

Bug Fix

Proposed Changes

  • Fixed cypress test for:
    • Auth
    • Forgot Password
    • Death Report
    • Sample test

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to the issue.
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team November 6, 2022 07:32
@aeswibon aeswibon requested a review from a team as a code owner November 6, 2022 07:32
@aeswibon aeswibon requested a review from gigincg November 6, 2022 07:32
@vercel
Copy link

vercel bot commented Nov 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 7:33AM (UTC)

@netlify
Copy link

netlify bot commented Nov 6, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 30fc6f4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/636762ffd523ac0008ce42bb
😎 Deploy Preview https://deploy-preview-3974--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 463704b into coronasafe:develop Nov 9, 2022
aeswibon added a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@aeswibon
fix(cypress): Cypress test are failing locally (coronasafe#3974)
0c68c65 
* test(auth): updated forgot password test

* test(auth): fixed auth test by changing name to id for getting input element

* test(death_report): fixed death_report test by adding force:true to Patients link

* test(sample_test): fixed sample_test test by using awaitUrl instead of clicking on sidebar items
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
needs testing urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cypress tests are failing locally
2 participants
@aeswibon @khavinshankar