Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the blank space at the bottom in ConsultationForm while updating #3979

Merged
merged 1 commit into from
Nov 6, 2022
Merged

Fixed the blank space at the bottom in ConsultationForm while updating #3979

merged 1 commit into from
Nov 6, 2022

Conversation

khavinshankar
Copy link
Member

Fixes #3976

Proposed Changes

  • The label in the select menu was having an absolute position, thus causing an overflow, so made it relative

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@khavinshankar khavinshankar added needs testing P1 breaking issue or vital feature labels Nov 6, 2022
@khavinshankar khavinshankar requested a review from a team November 6, 2022 09:50
@khavinshankar khavinshankar requested a review from a team as a code owner November 6, 2022 09:50
@vercel
Copy link

vercel bot commented Nov 6, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Nov 6, 2022 at 9:50AM (UTC)

@netlify
Copy link

netlify bot commented Nov 6, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ff171ad
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63678366130fd40009e25a9e
😎 Deploy Preview https://deploy-preview-3979--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad
Copy link
Member

@khavinshankar the issue is still present. However, it's solved in #3977
image

@khavinshankar
Copy link
Member Author

@khavinshankar the issue is still present. However, it's solved in #3977 image

@rithviknishad the issue seems to be present in the pr that you mentioned
https://deploy-preview-3977--care-net.netlify.app/facility/01810c32-ec26-494a-9e65-40e5547a7746/patient/9c6a4951-916e-439b-b41a-853b6980fefa/consultation/a8003ba0-9c0a-4d27-95b2-d3bd3139652f/update

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Nov 6, 2022
@rithviknishad
Copy link
Member

rithviknishad commented Nov 6, 2022 •
edited
Loading

@khavinshankar got it, it wasn't reproducible in firefox consistently but it was reproducible in chrome consistently. my bad

@nihal467
Copy link
Member

nihal467 commented Nov 6, 2022

test approved

@gigincg gigincg merged commit 898f762 into develop Nov 6, 2022
@khavinshankar khavinshankar deleted the fix#3976 branch November 13, 2022 06:04
aeswibon pushed a commit to aeswibon/care_fe that referenced this pull request Dec 8, 2022
@khavinshankar @aeswibon
fix (SelectMenuV2): made label relative (ohcnetwork#3979)
f590ae7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg gigincg approved these changes

@rithviknishad rithviknishad rithviknishad approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consultation page bottom limit is extending to a white screen
4 participants
@khavinshankar @rithviknishad @nihal467 @gigincg