Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: csv files are not in proper format #3980

Merged
merged 1 commit into from
Dec 16, 2022
Merged

fixed: csv files are not in proper format #3980

merged 1 commit into from
Dec 16, 2022

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Nov 6, 2022

Proposed Changes

  • Downgrade react-csv to v2.1.9

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to the issue.
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team November 6, 2022 09:51
@aeswibon aeswibon requested a review from a team as a code owner November 6, 2022 09:51
@aeswibon aeswibon requested a review from bodhish November 6, 2022 09:51
@vercel
Copy link

vercel bot commented Nov 6, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
care-storybook ✅ Ready (Inspect) Visit Preview Dec 15, 2022 at 1:02PM (UTC)

@netlify
Copy link

netlify bot commented Nov 6, 2022 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 373aab4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/639b1a69f7ca0b0008c6b625
😎 Deploy Preview https://deploy-preview-3980--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Nov 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Nov 8, 2022

@cp-Coder
image
issue still persist

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Nov 16, 2022
@gigincg
Copy link
Member

gigincg commented Nov 30, 2022

@cp-Coder Can your get this resolved?

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Dec 2, 2022
@github-actions
Copy link

github-actions bot commented Dec 2, 2022

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 11, 2022
@nihal467
Copy link
Member

@cp-Coder what is the status of the PR

@nihal467 nihal467 added the waiting for update PR is been dead for a long time label Dec 13, 2022
@github-actions github-actions bot removed the stale label Dec 14, 2022
@aeswibon aeswibon added needs testing and removed waiting for update PR is been dead for a long time merge conflict pull requests with merge conflict labels Dec 15, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 15, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@aeswibon
Copy link
Member Author

Demo

issue.3980.mp4

@nihal467
Copy link
Member

LGTM, @khavinshankar check it carefully

@khavinshankar
Copy link
Member

checked it in ubuntu -> chrome -> LibreOffice calc, works fine
LGTM

cc: @nihal467

@khavinshankar khavinshankar merged commit de94492 into coronasafe:develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility Downloaded Files are not in proper format
4 participants
@aeswibon @nihal467 @gigincg @khavinshankar